kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 104 forks source link

Download binaries from dl.k8s.io instead of a bucket #251

Closed upodroid closed 6 months ago

upodroid commented 7 months ago

/cc @ameukam @BenTheElder @dims

Fixes: https://github.com/kubernetes-sigs/kubetest2/issues/239 Part of: https://github.com/kubernetes/test-infra/issues/18789 and https://github.com/kubernetes/k8s.io/issues/2396

kops is another large project that fetches from the kubernetes-release/k8s-release-dev buckets but it has a custom implementation at https://github.com/kubernetes/kops/tree/master/tests/e2e/pkg/tester that I'll fix separately.

Lets merge this as soon as code freeze is over and bump the kubekins-e2e image. We should start seeing jobs failing and we can fix them

Improvements:

upodroid commented 6 months ago

/assign @michelle192837 @jbpratt /hold for updating prowjob PRs

This is ready to be merged. Jobs are passing

jbpratt commented 6 months ago

/lgtm /approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
upodroid commented 6 months ago

/hold cancel