search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
325 stars 104 forks source link

Add DeployerWithInit interface #253

Closed cartermckinnon closed 6 months ago

cartermckinnon commented 6 months ago

Adds a new interface that deployers can implement, DeployerWithInit, which allows a deployer to define initialization behavior. The deployer's Init function will be called prior to build/up/down/etc.

The initialization of a deployer may depend on its options, so cannot be done in NewDeployer (called when constructing the CLI).

k8s-ci-robot commented 6 months ago

@cartermckinnon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubetest2-gce-legacy-up-down b07ab779dbbff3e26bc68313962251b503d74583 link false /test pull-kubetest2-gce-legacy-up-down

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jbpratt commented 6 months ago

/approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon, jbpratt, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [jbpratt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment