search

kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
338 stars 110 forks source link

Dump cluster logs before bringing the cluster down #272

Closed soltysh closed 2 weeks ago

soltysh commented 1 month ago

Fixes https://github.com/kubernetes-sigs/kubetest2/issues/271

/assign @BenTheElder

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: soltysh Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aojea commented 2 weeks ago

/close

I inadvertently slipped this one and merged other similar to this, just replacing the defer to avoid dumping logs twice

https://github.com/kubernetes-sigs/kubetest2/pull/273/files

k8s-ci-robot commented 2 weeks ago

@aojea: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/kubetest2/pull/272#issuecomment-2454261582): >/close > >I inadvertently slipped this one and merged other similar to this, just replacing the defer to avoid dumping logs twice > >https://github.com/kubernetes-sigs/kubetest2/pull/273/files Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.