kubernetes-sigs / kubetest2

Kubetest2 is the framework for launching and running end-to-end tests on Kubernetes.
Apache License 2.0
338 stars 110 forks source link

build e2e requirements for kind deployer #275

Closed elieser1101 closed 2 weeks ago

elieser1101 commented 2 weeks ago

This should fix https://github.com/kubernetes-sigs/kubetest2/issues/184

This changes ensures e2e requirements can be found in _rundir/$KUBETEST2_RUN_DIR as described in https://github.com/kubernetes-sigs/kubetest2/blob/696b35899d305521225596d58cc27c33c6638994/pkg/testers/ginkgo/ginkgo.go#L50


I replicatrd the same behavior from https://github.com/kubernetes-sigs/kind/blob/main/hack/ci/e2e-k8s.sh#L72-L86

k8s-ci-robot commented 2 weeks ago

Welcome @elieser1101!

It looks like this is your first PR to kubernetes-sigs/kubetest2 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubetest2 has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 weeks ago

Hi @elieser1101. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aojea commented 2 weeks ago

/ok-to-test

aojea commented 2 weeks ago

it looks correct but I couldn't test it neither will have time soon to do it

elieser1101 commented 2 weeks ago
kubetest2 kind --build --test=ginkgo --up --down -- --focus-regex=<regex> --use-built-binaries

would be a new non blocking e2e test running the above passing be enough to help test this?

aojea commented 2 weeks ago
kubetest2 kind --build --test=ginkgo --up --down -- --focus-regex=<regex> --use-built-binaries

would be a new non blocking e2e test running the above passing be enough to help test this?

I'm fine with manual testing on this by now, have you verified it works?

/approve

defer final LGTM to @upodroid

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, elieser1101, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kubetest2/blob/master/OWNERS)~~ [aojea,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment