[dep] Updated `k8s.io/autoscaler/cluster-autoscaler` version to a stable one.

kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.26k stars 223 forks source link

[dep] Updated `k8s.io/autoscaler/cluster-autoscaler` version to a stable one. #1194

Closed trasc closed 1 month ago

trasc commented 9 months ago

What would you like to be cleaned:

Use a released version of k8s.io/autoscaler/cluster-autoscaler containing https://github.com/kubernetes/autoscaler/commit/5155725a28189cd1b65f001fcdf90699f5cde909

Why is this needed:

Have clean dependencies.

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tenzen-y commented 5 months ago

/remove-lifecycle stale

@trasc Since released the new cluster-autoscaler with PriviosningRequest API, we can do this, right?

trasc commented 4 months ago

@tenzen-y Indeed the the code we need is now part of a github release 1.29.0 but unfortunately the release is tagged with cluster-autoscaler-1.29.0 instead of cluster-autoscaler/v1.29.0 and it cannot be referenced from go.mod.

tenzen-y commented 4 months ago

@tenzen-y Indeed the the code we need is now part of a github release 1.29.0 but unfortunately the release is tagged with cluster-autoscaler-1.29.0 instead of cluster-autoscaler/v1.29.0 and it cannot be referenced from go.mod.

@trasc Yea, that makes sense. Indeed, I'm working on new tag format k8s.io/autoscaler/cluster-autoscaler/apis in https://github.com/kubernetes/autoscaler/pull/6315#issuecomment-1893441957.

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tenzen-y commented 1 month ago

/remove-lifecycle stale

tenzen-y commented 1 month ago

This is replaced with #1896 /close

k8s-ci-robot commented 1 month ago

@tenzen-y: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kueue/issues/1194#issuecomment-2107529221): >This is replaced with #1896 >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.