Improve integration coverage for jobset integration

kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.34k stars 235 forks source link

Improve integration coverage for jobset integration #1463

Open alculquicondor opened 9 months ago

alculquicondor commented 9 months ago

What would you like to be added:

The integration tests for JobSet are very basic. We should have more coverage around queuing multiple jobsets, preemptions, eviction due to timeout, etc.

A simple E2E test would be useful as well.

Why is this needed:

As an important investment for k8s, we need to ensure the jobset integration has the highest level of coverage possible.

Completion requirements:

This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

alculquicondor commented 9 months ago

@danielvegamyhre @kannon92 can any of you take this?

dejanzele commented 9 months ago

I also have capacity to help if they are currently unavailable

danielvegamyhre commented 9 months ago

@dejanzele go ahead, it would be much appreciated

alculquicondor commented 9 months ago

As part of the test cases, it would be good to include jobsets that have multiple resources, and use both parallelism and replicas.

dejanzele commented 9 months ago

/assign

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tenzen-y commented 5 months ago

/remove-lifecycle stale

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

alculquicondor commented 2 months ago

@dejanzele are you still working on this?

tenzen-y commented 2 months ago

/remove-lifecycle stale

dejanzele commented 2 months ago

@alculquicondor currently I don't have capacity in the following couple of weeks due to other work so I'll unassign myself. If it is still unassigned when I get more capacitiy, I will revisit this.

/unassign

highpon commented 2 months ago

/assign