kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.35k stars 238 forks source link

Improve Helm charts sync from Kustomize manifests #1798

Open astefanutti opened 7 months ago

astefanutti commented 7 months ago

What would you like to be added:

The Helm charts are currently synchronised from the Kustomize manifests, that are the source of truth for deploying Kueue, with the hack/update-helm.sh script, that performs a series of ad-hoc file manipulations using yq and sed commands.

It would be great to consider a more robust approach to generate the Helm charts from the Kustomize manifests. Part of the solution could be to move to a strongly typed approach, or (not necessarily mutually exclusive) add some tests that'd guarantee the generated Helm charts are valid.

Why is this needed:

1695#discussion_r1489203905.

This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

alculquicondor commented 6 months ago

Is this something you or your team is interested in taking?

astefanutti commented 6 months ago

That won't be a high priority for us as we're not using Helm charts.

I've created the issue more as a follow up from https://github.com/kubernetes-sigs/kueue/pull/1695#discussion_r1489203905 than something we would really need 🙂.

tenzen-y commented 6 months ago

@alculquicondor @astefanutti If this issue is not a high priority in both teams, should we mark this as a good-first-issue?

alculquicondor commented 6 months ago

I'm not sure it's a good "first" issue, but we can give it

/help

k8s-ci-robot commented 6 months ago

@alculquicondor: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/kueue/issues/1798): >I'm not sure it's a good "first" issue, but we can give it > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

Vandit1604 commented 5 months ago

/assign I'll take a look into this.

Vandit1604 commented 4 months ago

I'm unable to give time to this right now. Unassigning myself so someone else can give it a go.