Deprecate the `QueueVisibility` feature gate and corresponding API

kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.36k stars 241 forks source link

Deprecate the `QueueVisibility` feature gate and corresponding API #2256

Closed PBundyra closed 2 weeks ago

PBundyra commented 4 months ago

What would you like to be cleaned: I suggest coming with a plan to deprecate the QueueVisibility API. I would start with deprecating the QueueVisiblity feature gate and deleting logic behind it, and then remove the visibility field from ClusterQueue's Status when migrating to a next beta version of Kueue API.

Why is this needed: There was the visibility API introduced that covers all business needs that were cover by the QueueVisibility API and more. The visibility API resolves all drawback related to the QueueVisibility API and addresses its limitations. For now I don't see a rationale for maintaining the QueueVisiblity API. Additionally I believe having two different ways (and two feature gates) to monitor pending workloads may lead to a little confusion regarding their pros and cons.

PBundyra commented 4 months ago

@alculquicondor @mimowo @mwielgus @tenzen-y WDYT?

PBundyra commented 4 months ago

If you agree with this idea I will add this to the v1beta2 wishlist.

mimowo commented 4 months ago

Yeah, I never liked the mechanism, but we may want to seek additional community feedback at the batch-wg meeting / slack.

tenzen-y commented 4 months ago

I agree with you, but let's keep it while v1beta1 for the backward compatibility.

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tenzen-y commented 1 month ago

/remove-lifecycle stale

mimowo commented 4 weeks ago

I agree with you, but let's keep it while v1beta1 for the backward compatibility.

Keeping for backwards compatibility makes sense, but I think we can already deprecate it, so:

update the kube_features to mention it is deprecated, like here
and also mention it is deprecated in the docs.

mimowo commented 4 weeks ago

Just to x-reference the related effort of promoting the VisibilityOnDemand to beta: https://github.com/kubernetes-sigs/kueue/issues/2973

mimowo commented 2 weeks ago

@mbobrovskyi would you like to continue with this as a follow up to https://github.com/kubernetes-sigs/kueue/issues/2973?

mbobrovskyi commented 2 weeks ago

/assign