Remove deprecated ProvisioningRequest annotations

kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.44k stars 261 forks source link

Remove deprecated ProvisioningRequest annotations #2747

Open tenzen-y opened 3 months ago

tenzen-y commented 3 months ago

What would you like to be cleaned: Since this PR, we started supporting the new ProvisioningRequest annotations, but we did not remove deprecated annotations so that we can maintain backward compatibility with the previous ClusterAutoscaler versions.

So, based on the Kubernetes deprecation policy, as we discussed here, we would like to stop using deprecated ProvisioningRequest annotations here:

https://github.com/kubernetes-sigs/kueue/blob/e34732589c27f1d82f4e90c0d15c59ebb5f05e28/pkg/controller/admissionchecks/provisioning/constants.go#L22-L23

Why is this needed: Deprecated annotations will be removed in the future ClusterAutocaler version.

tenzen-y commented 3 months ago

cc: @PBundyra @yaroslava-serdiuk

kannon92 commented 3 months ago

/assign

Have https://github.com/kubernetes-sigs/kueue/pull/2753 up.

kannon92 commented 3 months ago

/priority important-long term

Deprecation should once 1.29 is out of support.

k8s-ci-robot commented 3 months ago

@kannon92: The label(s) priority/important-long, priority/term cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/kueue/issues/2747#issuecomment-2265208732): >/priority important-long term > >Deprecation should once 1.29 is out of support. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

kannon92 commented 3 months ago

/priority important-longterm

mimowo commented 3 months ago

IIUC https://github.com/kubernetes-sigs/kueue/pull/2753#issuecomment-2264632961, we should wait until 1.30.1 is EOL. This will take something like a year.

tenzen-y commented 3 months ago

IIUC #2753 (comment), we should wait until 1.30.1 is EOL. This will take something like a year.

I think so too.

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tenzen-y commented 2 weeks ago

/remove-lifecycle stale