search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.39k stars 254 forks source link

After the Jobs are stopped, Job PodTemplate Labels are not restored only during unit testing #3082

Closed tenzen-y closed 1 month ago

tenzen-y commented 1 month ago

What happened: Only during unit testing, the Job PodTemplate Labels (.spec.template.labels) are not restored. But, during integration testing and actual cluster running, they are restored after the Jobs are suspended.

What you expected to happen: The Job PodTemplate Labels are always restored after the Jobs are stopped.

How to reproduce it (as minimally and precisely as possible): We can see the reproduced PR and CI logs there:

Anything else we need to know?: We verify if those labels (.spec.template.labels) are restored only during the integration testing, and the testing always successful: https://github.com/kubernetes-sigs/kueue/blob/e812a0682a4d96b4a4a82f654202ce3d50d52541/test/integration/controller/jobs/job/job_controller_test.go#L756-L767

Environment:

mszadkow commented 1 month ago

/assign

mszadkow commented 1 month ago

@tenzen-y please have a look at my explanation here: https://github.com/kubernetes-sigs/kueue/pull/3081/files#r1766613892

tenzen-y commented 1 month ago

@tenzen-y please have a look at my explanation here: https://github.com/kubernetes-sigs/kueue/pull/3081/files#r1766613892

As I commented the above PR, this is my misunderstanding. @mszadkow Thank you for the investigation, again! /close

k8s-ci-robot commented 1 month ago

@tenzen-y: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kueue/issues/3082#issuecomment-2388954127): >> @tenzen-y please have a look at my explanation here: https://github.com/kubernetes-sigs/kueue/pull/3081/files#r1766613892 > >As I commented the above PR, this is my misunderstanding. >@mszadkow Thank you for the investigation, again! >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tenzen-y commented 1 month ago

/remove-kind bug /kind support