kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.34k stars 235 forks source link

Reevaluate the PodSpec equality factors #3103

Open tenzen-y opened 3 days ago

tenzen-y commented 3 days ago

What would you like to be added: We want to reevaluate the PodSpec equality factors and use only the necessary factors (fields) to identify the PodSpec.

https://github.com/kubernetes-sigs/kueue/blob/b9e173091c53456ae6858d9a10de81e6ba07ec62/pkg/util/equality/podset.go#L29-L37

Why is this needed: The current approach sometimes causes unexpected update detection as we discussed in https://github.com/kubernetes-sigs/kueue/issues/3090. So, it would be better to adopt the selective equality evaluation as opposed to the current nonselective equality.

Before we modify the actual equality function, we need to summarize the necessary fields for developers and users.

Completion requirements:

This enhancement requires the following artifacts:

The artifacts should be linked in subsequent comments.

tenzen-y commented 3 days ago

cc: @alculquicondor @dgrove-oss