search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.44k stars 261 forks source link

Make LossLessDefaulter selective to only prevent dropping fields outside of schema #3174

Closed mimowo closed 1 week ago

mimowo commented 1 month ago

What would you like to be added:

Investigate making the LossLessDefaulter in Kueue to only prevent dropping fields outside of schema. This is a follow up from the discussion: https://github.com/kubernetes-sigs/kueue/pull/3132#discussion_r1782255326

And follow up to the issue: https://github.com/kubernetes-sigs/kueue/issues/2878

Why is this needed:

Completion requirements:

Investigate if this is feasible. and what is the implementation complexity, prototype.

mimowo commented 1 month ago

/assign @tenzen-y per comment https://github.com/kubernetes-sigs/kueue/pull/3132#discussion_r1783163941 /cc @alculquicondor

tenzen-y commented 1 month ago

Sorry. I did not want to indicate taking this issue. /unassign

mimowo commented 1 month ago

Sorry, I misread your message which was clear. Thanks for clarifying! Anyway, the issue is open for contributions.

mbobrovskyi commented 1 month ago

/assign

mimowo commented 1 week ago

/close we don't need this in Kueue as there is fix in controller-runtime to be released, issue to track using the fix: https://github.com/kubernetes-sigs/kueue/issues/3469

k8s-ci-robot commented 1 week ago

@mimowo: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/kueue/issues/3174#issuecomment-2461674176): >/close >we don't need this in Kueue as there is fix in controller-runtime to be released, issue to track using the fix: https://github.com/kubernetes-sigs/kueue/issues/3469 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.