search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.47k stars 262 forks source link

Rename InactiveWorkload to Deactivated. #3593

Closed mbobrovskyi closed 4 days ago

mbobrovskyi commented 6 days ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Rename Workload Evicted condition reason InactiveWorkload to Deactivated.

Which issue(s) this PR fixes:

Fixes #3530

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The InactiveWorkload reason for the Evicted condition is renamed to Deactivated.

Also, the reasons for more detailed situations are renamed:
- InactiveWorkloadAdmissionCheck -> DeactivatedDueToAdmissionCheck
- InactiveWorkloadRequeuingLimitExceeded -> DeactivatedDueToRequeuingLimitExceeded

ACTION REQUIRED: If you were watching for the "InactiveWorkload" reason in the "Evicted" condition, you need
to start watching for the "Deactivated" reason.
netlify[bot] commented 6 days ago

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
Latest commit 3e7c14a641ee745d683cb859187914fd2631e621
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673f1bf4cc13ac0008ff8ab4
mimowo commented 6 days ago

/hold until we figure out a strategy for smooth upgrade

PBundyra commented 4 days ago

Overall LGTM, please improve clarity of the release note

mimowo commented 4 days ago

/release-note-edit

The InactiveWorkload reason for the Evicted condition is renamed to Deactivated.

Also, the reasons for more detailed situations are renamed:
- InactiveWorkloadAdmissionCheck -> DeactivatedDueToAdmissionCheck
- InactiveWorkloadRequeuingLimitExceeded -> DeactivatedDueToRequeuingLimitExceeded

ACTION REQUIRED: If you were watching for the "InactiveWorkload" reason in the "Evicted" condition, you need
to start watching for the "Deactivated" reason.
mimowo commented 4 days ago

/lgtm /approve

k8s-ci-robot commented 4 days ago

LGTM label has been added.

Git tree hash: 8a6bd8eee7ac4f135d584dca0a739aa851c0a150

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimowo commented 4 days ago

/hold cancel The new version supports smooth upgrade, where the deactivated workloads remain deactivated.