Use g.Expect instead of gomega.Expect on gomega.Eventually.

kubernetes-sigs / kueue

Kubernetes-native Job Queueing

https://kueue.sigs.k8s.io

Apache License 2.0

1.47k stars 262 forks source link

Use g.Expect instead of gomega.Expect on gomega.Eventually. #3607

Closed mbobrovskyi closed 4 days ago

mbobrovskyi commented 4 days ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use g.Expect instead of gomega.Expect on gomega.Eventually.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We can't use gomega.Expect on Eventually if we are using g gomega.Gomega. It will stop Eventually on first error.

Does this PR introduce a user-facing change?

NONE

netlify[bot] commented 4 days ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
Latest commit	2d6d435e939f9f2278e9324467ca5b8bddcf0eae
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673f02f7531c7c0008f88e53
Deploy Preview	https://deploy-preview-3607--kubernetes-sigs-kueue.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mbobrovskyi commented 4 days ago

/cc @mimowo

k8s-ci-robot commented 4 days ago

LGTM label has been added.

Git tree hash: f3989d1ba4ddf8bf219c5f2d47c2ffbd09a62b64

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/test/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment