search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.47k stars 262 forks source link

Replace bytes.NewReader with strings.NewReader #3619

Closed alexandear closed 13 hours ago

alexandear commented 1 day ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR refactors code by replacing bytes.NewReader([]byte(str)) with strings.NewReader(str) to avoid extra allocation and shorten statements.

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 1 day ago

Hi @alexandear. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 day ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit e13064c790f98376846429342cf11f3aaf21bfa9
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67435c90d1172d0008018db5
Deploy Preview https://deploy-preview-3619--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 13 hours ago

LGTM label has been added.

Git tree hash: 66dd8343dc7b94004c14f307b85ce0d507760f25

k8s-ci-robot commented 13 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[cmd/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/cmd/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment