search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.47k stars 262 forks source link

Automated cherry pick of #3603: [MultiKueue] fix using MultiKueue when some integrations are disabled #3631

Closed mszadkow closed 8 hours ago

mszadkow commented 8 hours ago

Cherry pick of #3603 on release-0.9.

3603: GetMultiKueueAdapters() returns only registered and enabled

Manually resolved conflict: Remove fakeClock from TestWlReconcile

For details on the cherry pick process, see the cherry pick requests page.

Fix the bug which prevented the use of MultiKueue if there is a CRD which is not installed
and removed from the list of enabled integrations.
netlify[bot] commented 8 hours ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit c5d1e29246e4771b72247481af137e40721b4cb9
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6744612c2720160008805eba
Deploy Preview https://deploy-preview-3631--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mimowo commented 8 hours ago

@mszadkow please briefly summarize what was adjusted manually when resolving conflicts

mimowo commented 8 hours ago

/kind bug

mimowo commented 8 hours ago

/release-note-edit

Fix the bug which prevented the use of MultiKueue if there is a CRD which is not installed
and removed from the list of enabled integrations.
mimowo commented 8 hours ago

/retitle Automated cherry pick of #3603: [MultiKueue] fix using MultiKueue when some integrations are disabled

mimowo commented 8 hours ago

Thanks, I see the manual adjustment is explained Manually resolved conflict: Remove fakeClock from TestWlReconcile

/lgtm /approve

k8s-ci-robot commented 8 hours ago

LGTM label has been added.

Git tree hash: 38985c250faf7c70987652f8892aae160b2e8deb

k8s-ci-robot commented 8 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, mszadkow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[cmd/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/release-0.9/cmd/OWNERS)~~ [mimowo] - ~~[pkg/controller/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/release-0.9/pkg/controller/OWNERS)~~ [mimowo] - ~~[test/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/release-0.9/test/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimowo commented 8 hours ago

/release-note-edit

Fix the bug which prevented the use of MultiKueue if there is a CRD which is not installed
and removed from the list of enabled integrations.