kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.47k stars 262 forks source link

TAS: fix panic in e2e test when parallelism < completions #3632

Closed mimowo closed 7 hours ago

mimowo commented 8 hours ago

What type of PR is this?

/kind bug /kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3620

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE
k8s-ci-robot commented 8 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/kubernetes-sigs/kueue/blob/main/test/OWNERS)~~ [mimowo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mimowo commented 8 hours ago

/assign @mbobrovskyi

netlify[bot] commented 8 hours ago

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
Latest commit 2438a2e213a3bad5b7ff0ffa9fb8d3a5c41d69c3
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67446823272016000883817f
Deploy Preview https://deploy-preview-3632--kubernetes-sigs-kueue.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mimowo commented 8 hours ago

cc @PBundyra

mimowo commented 7 hours ago

/test pull-kueue-test-integration-main unrelated, opened issue: https://github.com/kubernetes-sigs/kueue/issues/3633

mbobrovskyi commented 7 hours ago

/lgtm Thanks!

k8s-ci-robot commented 7 hours ago

LGTM label has been added.

Git tree hash: 1668a2c4e6f2289cd61395ae12e61b5dc208a0bb

mbobrovskyi commented 7 hours ago

/retest

Due to know issue.