search

kubernetes-sigs / kueue

Kubernetes-native Job Queueing
https://kueue.sigs.k8s.io
Apache License 2.0
1.5k stars 268 forks source link

TAS: cache information is not updated when RF spec (nodeTaints or tolerations) is changed #3733

Open mimowo opened 9 hours ago

mimowo commented 9 hours ago

What happened:

When TAS RF is updated (e.g. nodeTaints or tolerations), then the cache information is not updated.

What you expected to happen:

Update the cache or fail the update. I think updating cache would be ideal, but it might be hard to deliever before 0.10, so we may just block updates for now (when topologyName is specified).

How to reproduce it (as minimally and precisely as possible):

Create a TAS setup, and add the .spec.tolerations. issue: the tolerations are not added to the newly admitted workloads.

Anything else we need to know?:

We had a similar decision about update to the levels and decided to block updates for now: https://github.com/kubernetes-sigs/kueue/issues/3614

mimowo commented 9 hours ago

/assign @PBundyra tentatievly cc @mbobrovskyi