fix: prescan for offline clients may fail to register commands - Githubissues

kubernetes-sigs / kui

A hybrid command-line/UI development experience for cloud-native development

Apache License 2.0

2.84k stars 183 forks source link

fix: prescan for offline clients may fail to register commands #9250

Closed starpit closed 1 year ago

starpit commented 1 year ago

Capabilities.inBrowser() should return true when prescanning for command registrations for offline clients.

Description of what you did:

Required Items

[x] Your PR consists of a single commit (i.e. squash your commits)
[x] Your commit and PR title starts with one of fix: | test: | chore: | doc:, to indicate the nature of the fix (see Conventional Commits)

Optional Items

[ ] 💥 This PR involves a breaking change. If so, include "BREAKING CHANGE: ...why..." in the commit and PR message.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kui/blob/master/OWNERS)~~ [starpit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment