search

kubernetes-sigs / kui

A hybrid command-line/UI development experience for cloud-native development
Apache License 2.0
2.81k stars 183 forks source link

Uncaught TypeError exception after kubectl kui if kui window is already open #9351

Closed sergray closed 1 year ago

sergray commented 1 year ago

Describe the bug

Uncaught TypeError exception after kubectl kui if kui window is already open

Steps to reproduce the behavior

  1. Install kui with brew install kui
  2. Open terminal and run kubectl kui
  3. kui window opens
  4. Run kubectl kui in the terminal again
  5. See error 
    A JavaScript error occurred in the main process
Uncaught Exception:
TypeError: Cannot read properties of null (reading 'env')
at App.<anonymous> (/Applications/Kui.app/Contents/Resources/app/dist/headless/7255.kui.min.js:1:15573)
at App.emit (node:events:513:28)

Expected behavior Focus goes to the open kui window and result of the command is shown there

Screenshots Window with the error image

Code snippets Not applicable

System

starpit commented 1 year ago

thanks for the bug report! we recently noticed this regression, too :(

we'll get on it!

starpit commented 1 year ago

The fix has been released in 13.1.4.

sergray commented 1 year ago

Thank you very much for such a quick fix and release! I confirm it is working.

Op do 20 apr. 2023 21:50 schreef Nick Mitchell @.***>:

The fix has been released in 13.1.4.

— Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/kui/issues/9351#issuecomment-1516863524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABPWNPKH3D5ZBV4ZOYIM6LXCGHPDANCNFSM6AAAAAAXFM7LYY . You are receiving this because you authored the thread.Message ID: @.***>