kubernetes-sigs / kui

A hybrid command-line/UI development experience for cloud-native development
Apache License 2.0
2.81k stars 183 forks source link

fix: second-instance additionalData may be null #9352

Closed starpit closed 1 year ago

starpit commented 1 year ago

Description of what you did:

This works around an issue where the additionalData parameter is null when using "popup window" mode. Since it is null, env vars, etc. from the second instance will not be transmitted to the first. But for now, we need to fix the bad behavior where one cannot even open a second window.

Fixes #9351

Required Items

Optional Items

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kui/blob/master/OWNERS)~~ [starpit] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment