search

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations
Apache License 2.0
11.02k stars 2.25k forks source link

Graduate Kustomize cfg read-only commands out of alpha #4090

Open KnVerey opened 3 years ago

KnVerey commented 3 years ago

Related to #3953 , which deprecates the rest of the cfg group. The commands in question are:

  cat           [Alpha] Print Resource Config from a local directory.
  count         [Alpha] Count Resources Config from a local directory.
  grep          [Alpha] Search for matching Resources in a directory or from stdin
  tree          [Alpha] Display Resource structure from a directory or stdin.

IMO to keep the read-only commands rather than deprecate them as well, we should:

k8s-ci-robot commented 3 years ago

@KnVerey: This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
natasha41575 commented 3 years ago

Reconsider whether cfg is the prefix we want permanently. @bgrant0607 suggested view, browse or scan as alternatives.

If we do this, I like scan the most.

Make these command support inflating the Kustomization in the targeted directory. In fact, that should probably be the default, since these are kustomize subcommands not, e.g. kubectl plugins.

So, we would have inflation of the kustomization by default? Would there be an option to use these commands without inflation, say kustomize scan cat . --no-inflate?

KnVerey commented 3 years ago

So, we would have inflation of the kustomization by default? Would there be an option to use these commands without inflation, say kustomize scan cat . --no-inflate?

I could be convinced otherwise, but yes, that's what I'm thinking

bgrant0607 commented 3 years ago

If an on-the-fly build is done first, then this has a dependency on #3979

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

natasha41575 commented 3 years ago

/remove-lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

natasha41575 commented 2 years ago

/remove-lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

KnVerey commented 2 years ago

/remove-lifecycle stale

annasong20 commented 2 years ago

@KnVerey suggests adding diff functionality: https://github.com/kubernetes-sigs/kustomize/pull/4590#discussion_r873197339

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

KnVerey commented 2 years ago

/lifecycle frozen

natasha41575 commented 1 year ago

/triage accepted

We need to follow the guidelines outlined in https://github.com/kubernetes-sigs/kustomize/issues/4090#issuecomment-892030365 to move this issue forward.

k8s-triage-robot commented 2 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

annasong20 commented 2 months ago

/uncc