Convert `resources` and `components` to be backed by a reusable generator

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations

Apache License 2.0

10.77k stars 2.22k forks source link

Convert `resources` and `components` to be backed by a reusable generator #4402

Open KnVerey opened 2 years ago

KnVerey commented 2 years ago

This is required for the Composition KEP, so that Compositions can use these key features.

Kustomize Plugin Composition API #2299

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

KnVerey commented 2 years ago

/remove-lifecycle stale

natasha41575 commented 2 years ago

For anyone interested in working on this, there is a brief description of how our generators/transformers are implemented in this comment. https://github.com/kubernetes-sigs/kustomize/issues/4671#issuecomment-1150433981

You can take the ConfigMapGenerator as an example. We want a plugin like that called ResourceGenerator, except instead of generating a ConfigMap, it should generate resources by reading from the resources field of the kustomization file.

Running make should automatically update our builtin plugins here and after that there will be some more work to hook up the resources field to invoke the new ResourceGenerator.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

KnVerey commented 1 year ago

/kind cleanup /lifecycle frozen

swastik959 commented 1 year ago

@KnVerey hi I have tried to work on the issue and create a pull request can you please take a look

natasha41575 commented 1 year ago

Hi @swastik959, apologies, but I think this issue is complicated and your PR does not completely resolve the issue. I think this issue requires a bit more context and @koba1t is going to work on it, as he has been working on kustomize for a longer time and has the context to understand the full requirements.

Please feel free to take a look at issues labeled "good first issue" or "help wanted".

/assign @koba1t

k8s-triage-robot commented 1 month ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

koba1t commented 1 month ago

/triage accepte

k8s-ci-robot commented 1 month ago

@koba1t: The label(s) triage/accepte cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/kustomize/issues/4402#issuecomment-2171846785): >/triage accepte Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

koba1t commented 1 month ago

/triage accepted