Closed GuyPaddock closed 6 days ago
/triage under-consideration
I think this sounds reasonable, but I'd like to get @natasha41575 opinion on it.
A coupld thoughts:
1) As a parallel, it might be useful/elegant to similarly respect a source.options.delimiter
when no source.options.index
is specified to split a source scalar and then pass it to targets as a slice.
2) A potentially thorny edge-case occurred to me: what do you do when the source array is not an array of scalars or is a mix of scalars and non-scalars? E.g. what happens if your source finds this:
- hello
- world
- key1: val1
key2: val2
- - itemA
- itemB
A potential solution could be introducing another option (perhaps coerce
?) to coerce the source into a scalar if the target is a scalar, which would also make it possible to join multiple snippets to build up a scalar file when using a '\n'
delimiter
Another use case for a coerce (to string) option would be if the duck typing of the reference field mistakenly treats it as a number:
replacements:
- source:
kind: Deployment
fieldPath: spec.template.spec.containers.[name=mycontainer].image
options:
delimiter: ":"
index: 1
targets:
- select:
kind: Deployment
fieldPaths:
- metadata.labels.version
- spec.template.metadata.labels.version
options:
create: true
This causes errors with k8s if the tag convention happens to be X.Y
and due to certain metadata fields expected to be map[string]string.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
/reopen
@GuyPaddock: Reopened this issue.
/remove-lifecycle rotten
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
/reopen
@GuyPaddock: Reopened this issue.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
Eschewed features
What would you like to have added?
Given the following custom-resource Yaml:
... I'd like a way to join all of the values under
data.addresses
into a comma-delimited string (e.g., for use in annginx.ingress.kubernetes.io/whitelist-source-range
annotation) using a replacement, like this:For example:
Why is this needed?
nginx.ingress.kubernetes.io/whitelist-source-range
), while others require it as an array (spec.loadBalancerSourceRanges
in services). By providing a way to join these values by a delimiter, both can be provided with values sourced from the same source data.delimiter option can only be used with scalar nodes
index
, so there is precedent for this feature.Can you accomplish the motivating task without this feature, and if so, how?
What other solutions have you considered?
Anything else we should know?
No response
Feature ownership