Fix gorepomod make test

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations

Apache License 2.0

10.94k stars 2.24k forks source link

Fix gorepomod make test #5637

Closed karlkfi closed 5 months ago

koba1t commented 5 months ago

I think this make command was broken.

$ make usage.go
Makefile:13: warning: overriding commands for target `test'
../../Makefile-modules.mk:24: warning: ignoring old commands for target `test'
cd /Users/kob/git/kustomize/hack && go install golang.org/x/tools/cmd/goimports
go generate . \
        /Users/kob/go/bin/goimports -w usage.go
named files must be .go files: .

karlkfi commented 5 months ago

Correct. Thats what this PR fixes.

koba1t commented 5 months ago

/lgtm /approve

k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karlkfi, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kustomize/blob/master/OWNERS)~~ [koba1t] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment