search

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations
Apache License 2.0
10.94k stars 2.24k forks source link

kustomize example in README uses deprecated commonLabels #5653

Open paololazzari opened 5 months ago

paololazzari commented 5 months ago

What happened?

When running the example in the README:

# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Kustomize version

v5.4.1

k8s-ci-robot commented 5 months ago

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
varshaprasad96 commented 5 months ago

@paololazzari Thanks for brining up this issue. The docs do seem to be outdated: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/.

Would you be open to submitting a PR to fix this in the docs website. Any help from the community is appreciated. Thanks!

varshaprasad96 commented 5 months ago

cc: @ncapps

ah8ad3 commented 5 months ago

Maybe i can help with this issue.

ah8ad3 commented 5 months ago

The docs do seem to be outdated: https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/.

@varshaprasad96 The actual version of Kustomize inside kubectl is old i don't think we should update this until the version is bumped up. Instead i think we should update this site, https://kubectl.docs.kubernetes.io/references/kustomize/ Also the examples.