Using digest and newTag outputs both when docs indicate newTag is ignored

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations

Apache License 2.0

10.94k stars 2.24k forks source link

Using digest and newTag outputs both when docs indicate newTag is ignored #5664

Open obs-gh-danielmartin opened 5 months ago

obs-gh-danielmartin commented 5 months ago

https://github.com/kubernetes-sigs/kustomize/blob/ed09399cd1fa66b9290058ea909025385400f434/api/types/image.go#L23

Since #4406 this is no longer true. If tag and digest are both specified, both tag and digest will be included in the new image string. This is probably fine for the majority of use cases, but if previously relying on the digest for immutability and tag for human readability, this unexpectedly results in resource updates/restarts when the tag is changed (which previously wasn't included in the resulting output) but the digest is unchanged.

k8s-ci-robot commented 5 months ago

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle rotten
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

stormqueen1990 commented 1 month ago

/lifecycle frozen