search

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations
Apache License 2.0
10.7k stars 2.22k forks source link

chore: restore version for github.com/asaskevich/govalidator #5680

Closed koba1t closed 2 months ago

koba1t commented 2 months ago

@liggitt care about to update github.com/asaskevich/govalidator for k/k repo. https://github.com/kubernetes/kubernetes/pull/124217#discussion_r1561186183

I think this bump was triggered by me, and I think I didn't have any special reason to update that... https://github.com/kubernetes-sigs/kustomize/pull/5187/files#diff-8fb0bb262dbf15787a049f76fe5fd9a6524c8a0614ab542411d950b030a785ffL25-R25

So, I think we can try to revert this change.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/kustomize/blob/master/OWNERS)~~ [koba1t,varshaprasad96] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment