search

kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations
Apache License 2.0
10.7k stars 2.22k forks source link

fix: include label in templates when adding by cli #5682

Open kozjan opened 2 months ago

kozjan commented 2 months ago

Related to this comment: https://github.com/kubernetes-sigs/kustomize/issues/1009#issuecomment-1607147158

added --include-templates to add labels to templates when using kustomize edit add label

k8s-ci-robot commented 2 months ago

Welcome @kozjan!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 2 months ago

Hi @kozjan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 2 months ago

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kozjan commented 1 month ago

Hi there, @kozjan! 👋🏻

Thank you for your contribution!

This looks mostly good to me. However, this implementation requires --without-selector to be specified and there's no added validation for that. Could you please update validateAndParse to ensure that any invocation of kustomize edit add label --include-templates fails when --without-selector is not specified, as well as an extra test case for that scenario?

@stormqueen1990 hey, can you check it out again?

varshaprasad96 commented 1 month ago

/ok-to-test

k8s-ci-robot commented 1 month ago

New changes are detected. LGTM label has been removed.

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kozjan Once this PR has been reviewed and has the lgtm label, please ask for approval from stormqueen1990. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[kustomize/OWNERS](https://github.com/kubernetes-sigs/kustomize/blob/master/kustomize/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
stormqueen1990 commented 1 month ago

/easycla

stormqueen1990 commented 1 month ago

Hi there, @kozjan! It looks like there was a lint failure, could you please take a look at that?

It also seems like EasyCLA couldn't pick up the commit identity correctly for the commit made via GitHub CLI. It might be a good idea to squash the commits and see if that works.

kozjan commented 3 weeks ago

Hi there, @kozjan! It looks like there was a lint failure, could you please take a look at that?

It also seems like EasyCLA couldn't pick up the commit identity correctly for the commit made via GitHub CLI. It might be a good idea to squash the commits and see if that works.

hey @stormqueen1990, sorry for getting back so late I squashed review fixes + lint fix into last commit.