kubernetes-sigs / kustomize

Customization of kubernetes YAML configurations
Apache License 2.0
10.7k stars 2.22k forks source link

fix:kustomize cfg grep with no arguments causes panic #5707

Open yeedove opened 1 month ago

yeedove commented 1 month ago
➜  ✗ kustomize cfg grep                                
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
sigs.k8s.io/kustomize/cmd/config/internal/commands.(*GrepRunner).preRunE(0x104cf5ad0?, 0x0?, {0x105ac5f68?, 0x104cf0f8c?, 0x1400018bd00?})
          /Users/denniszh/kustomize/cmd/config/internal/commands/grep.go:69 +0x3bc
github.com/spf13/cobra.(*Command).execute(0x14000287b08, {0x105ac5f68, 0x0, 0x0})
        /Users/denniszh/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:968 +0x7e8
github.com/spf13/cobra.(*Command).ExecuteC(0x140001e2608)
         /Users/denniszh/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115 +0x344
github.com/spf13/cobra.(*Command).Execute(0x1059bbfa8?)
        /Users/denniszh/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039 +0x1c
main.main()
       /Users/denniszh/kustomize/kustomize/main.go:14 +0x20

Examples:

# find Deployment Resources
kustomize cfg grep "kind=Deployment" my-dir/

# find Resources named nginx
kustomize cfg grep "metadata.name=nginx" my-dir/

# use tree to display matching Resources
kustomize cfg grep "metadata.name=nginx" my-dir/ | kustomize cfg tree

# look for Resources matching a specific container image
kustomize cfg grep "spec.template.spec.containers[name=nginx].image=nginx:1\.7\.9" my-dir/ | kustomize cfg tree

Flags: --annotate annotate resources with their file origins. (default true) -h, --help help for grep --invert-match Selected Resources are those not matching any of the specified patterns.. -R, --recurse-subpackages also print resources recursively in all the nested subpackages (default true)

Global Flags: --stack-trace print a stack-trace on error



Fixes: #5701 
k8s-ci-robot commented 1 month ago

Welcome @yeedove!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

Hi @yeedove. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yeedove Once this PR has been reviewed and has the lgtm label, please assign knverey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/kustomize/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 1 month ago

This PR has multiple commits, and the default merge method is: merge. You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
stormqueen1990 commented 3 weeks ago

/ok-to-test /label tide/merge-method-squash