k8s-ci-robot
commented
2 months ago This issue is currently awaiting triage.
SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ctenberge-oneid
Eschewed features
What would you like to have added?
I want a min and max key on the list in the replicas-transformer. This should only apply to resources that have those, like HPA.
Why is this needed?
With the replicas transformer, I do not need to write a custom patch for deployment (and such) replicas changes. For HPA, I still need the patch, though I covers the same "scaling"-issue.
Can you accomplish the motivating task without this feature, and if so, how?
The current solution is writing a (yaml/strategic merge) patch, just like I did with plain (deployment) replicas before.
What other solutions have you considered?
An inline json-patch, but that is really less readable.
Anything else we should know?
This seems like the next logical step after #1139. I am not proficient in go, but willing to try to contribute something useful. I might need some guidance and mentorship.
Feature ownership