kubernetes-sigs / lwkd

Last Week in Kubernetes Development
https://lwkd.info/
Creative Commons Attribution 4.0 International
127 stars 34 forks source link

Replace deprecated command with environment file #284

Closed jongwooo closed 9 months ago

jongwooo commented 9 months ago

Description

Closes #283

Update .github/workflows/get-releases-weekly.yaml to use environment file instead of deprecated set-output command. For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow file that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo "::set-output name=date::$(date +'%Y-%m-%d')"

TO-BE

run: echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT
sreeram-venkitesh commented 9 months ago

@mfahlandt would be the right person to review this

mfahlandt commented 9 months ago

tested it and works /lgtm

k8s-ci-robot commented 9 months ago

@mfahlandt: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes-sigs/lwkd/pull/284#issuecomment-1875870445): >tested it and works >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sreeram-venkitesh commented 9 months ago

/lgtm

jberkus commented 9 months ago

/approve

Thanks for the fix!

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, jongwooo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/lwkd/blob/main/OWNERS)~~ [jberkus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment