System metrics support - Githubissues

kubernetes-sigs / lws

LeaderWorkerSet: An API for deploying a group of pods as a unit of replication

Apache License 2.0

121 stars 23 forks source link

System metrics support #87

Open kerthcet opened 5 months ago

kerthcet commented 5 months ago

What would you like to be added:

We should add some metrics for tracking the health of the system, some of them like:

Rolling update duration
Recreate group times
HPA related? Like scaling up/down times & duration?

Please add more if you think so.

Why is this needed:

Providing insight of the system

Completion requirements:

This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

liurupeng commented 5 months ago

+1 this should be pretty useful. How about "latency for pod be scheduled and become ready"?

kerthcet commented 5 months ago

Or do you mean Replica? Pod seems not that important.

liurupeng commented 5 months ago

Or do you mean Replica? Pod seems not that important.

yep, Replica makes sense

Edwinhr716 commented 5 months ago

/assign

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

kerthcet commented 2 months ago

/remove-lifecycle stale

googs1025 commented 1 week ago

"Hey, do we still need this feature? I'm not sure why the PR got closed back then and nothing happened afterwards. If it is still needed, I can take a shot at it." @kerthcet @liurupeng @Edwinhr716 Or, it would be great if Edwinhr716 is willing to re-promote this PR

Edwinhr716 commented 1 week ago

The PR got closed due to lack of clarity on what each metric was measuring. If we want to continue with the issue, it would be good to agree on what metrics we want to be added and what each metric entails

kerthcet commented 1 week ago

Yes, we do. I'll categorize them once I had time and submit a pr as a demo.