Update Test 1 / "connectivity_test" to confirm expected endpoints

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.

Apache License 2.0

199 stars 39 forks source link

Update Test 1 / "connectivity_test" to confirm expected endpoints #15

Closed lauralorenz closed 1 year ago

lauralorenz commented 1 year ago

Per the KEP, we must test that

Test cluster A can contact service imported from cluster B and route to expected endpoints.

Today, the connectivity_test (which I also refer to as Test 1) confirms the first part ("contact") but does not confirm the second part ("route to expected endpoints"). It does this by confirming that something responded to a request for the Service IP, and that its response contains some text it expects (reference).

This issue is done when this test also gathers the expected pod IPs for the pods in the deployment backing the Service in the source cluster B first*, and then confirming during the connectivity test that it is those IPs and only those IPs that are responding to the Service IP request.

*This should probably be done by collecting the source cluster's Pod.Spec.IPs through the k8s API, and probably be implemented in a separate method that can be used by Test 3 later.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lauralorenz commented 1 year ago

/assign knee-berts /remove-lifecycle stale

k8s-ci-robot commented 1 year ago

@lauralorenz: GitHub didn't allow me to assign the following users: knee-berts.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/mcs-api/issues/15#issuecomment-1309048635): >/assign knee-berts >/remove-lifecycle stale Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lauralorenz commented 1 year ago

/assign lauralorenz @knee-berts is helping me with this one