kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

Create Test 2 / "local service not impacted" e2e test #16

Open lauralorenz opened 1 year ago

lauralorenz commented 1 year ago

Per the KEP, an e2e test must exist that tests:

Test cluster A local service not impacted by same-name imported service.

We define "not impacted" as:

Not impacted = when you run a Service in cluster A called foo, and you have a ServiceImport for foo, you can still resolve foo.ns.svc.cluster.local and and its IP is different from the ServiceImport IP and when you actually request the local service IPs you get a response back and its the right response (so we have to make the response smart, such as reporting their clusterID) foo.ns.svc.clusterset.local will sometimes return clusterB foo.ns.svc.cluster.local will always (always=50 times in a row) return cluster A

Given a setup with two clusters, this test should do the following:

See the existing connectivity test for inspiration on setup and potential request and response pods. Notably in this case the response needs to be smart enough to share what cluster it is in.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lauralorenz commented 1 year ago

/remove-lifecycle stale

lauralorenz commented 1 year ago

/assign lauralorenz @knee-berts is helping me with this one

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

lauralorenz commented 1 year ago

/remove-lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/mcs-api/issues/16#issuecomment-1900100009): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
nojnhuh commented 1 month ago

I can take this one!

/reopen /assign

k8s-ci-robot commented 1 month ago

@nojnhuh: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/issues/16#issuecomment-2110599972): >I can take this one! > >/reopen >/assign Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nojnhuh commented 1 month ago

/remove-lifecycle rotten

nojnhuh commented 1 month ago

Sorry @lauralorenz didn't catch that you were already assigned to this. Don't mean to step on your toes, but happy to pick this up!

nojnhuh commented 1 month ago

@lauralorenz Just to clarify since these tests involve setting up DNS, is compiling our own CoreDNS with https://github.com/coredns/multicluster and configuring that for kind the recommended approach? Are there any other steps required to make the clusterset.local domain reachable?

nojnhuh commented 1 month ago

@lauralorenz Just to clarify since these tests involve setting up DNS, is compiling our own CoreDNS with https://github.com/coredns/multicluster and configuring that for kind the recommended approach? Are there any other steps required to make the clusterset.local domain reachable?

I think I got this working here: #50