kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

Finished e2e-test #1 #18

Closed knee-berts closed 1 year ago

knee-berts commented 1 year ago

What type of PD is this? /kind cleanup /kind e2e-test /kind needs-kind

What this PD does / why we need it: Closes #15 Added a method to e2etests that collects destination pods IP via k8s downward api. Added a method that emulates kubectl exec command and returns stdout. Runs each test (TCP and UDP) 50 times and validates that the Pod IP returned in the test is the destination pod IP. Pinned kind configs to a version where endpointslices are Beta.

k8s-ci-robot commented 1 year ago

@knee-berts: The label(s) kind/e2e-test cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/pull/18): >What type of PD is this? >/kind cleanup >/kind e2e-test > >What this PD does / why we need it: >Closes #14 >Added a method to e2etests that collects destination pods IP via k8s downward api. >Runs each test (TCP and UDP) 50 times and validates that the Pod IP returned in the test is the destination pod IP. >Pinned kind configs to a version where endpointslices are Beta. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

Welcome @knee-berts!

It looks like this is your first PR to kubernetes-sigs/mcs-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/mcs-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

lauralorenz commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knee-berts, lauralorenz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)~~ [lauralorenz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment