search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

Update e2e tests to support k8s 1.21+ only, particularly to fix EndpointSlice version errors when using them today #19

Closed lauralorenz closed 1 month ago

lauralorenz commented 1 year ago

We happen to be observing a breakage in our e2e tests against clusters running above Kubernetes version 1.21. This is because the MCS API is dependent on EndpointSlices and the e2e tests happened to have been written when EndpointSlice was in v1beta1 and implemented as such, but which GA'd to v1 in Kubernetes 1.21.

Per discussion in SIG-MC today 11/15/2022, e2etests have a lower standard of backwards compatibility than vendor implementations might choose, and we are ok with making them work against only the GA version of EndpointSlice, even in their role as conformance tests. Some of the reasons given were because it's been out for longer than a year, that in the purview of MCS API history its been a stable dependency, etc.

lauralorenz commented 1 year ago

/help

k8s-ci-robot commented 1 year ago

@lauralorenz: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/issues/19): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lauralorenz commented 1 year ago

/assign lauralorenz @IshmeetMehta is helping with this one

lauralorenz commented 1 year ago

I think this is fixed by #24

lauralorenz commented 1 year ago

Can confirm this is fixed by #24, just need to remove the pin on 1.21 in the cluster setup (ie https://github.com/kubernetes-sigs/mcs-api/blob/master/scripts/c1.yaml#L10)

sbdtu5498 commented 1 year ago

/assign