search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

Upgraded Ginkgo to v2 #30

Closed knee-berts closed 1 year ago

knee-berts commented 1 year ago

What type of PD is this? /kind cleanup /kind e2e-test

What this PD does / why we need it: Gingko v1 is deprecated. This PR updates Gingko to v2.7.0

k8s-ci-robot commented 1 year ago

@knee-berts: The label(s) kind/e2e-test cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/pull/30): >What type of PD is this? >/kind cleanup >/kind e2e-test > >What this PD does / why we need it: >Gingko v1 is deprecated. This PR updates Gingko to v2.7.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knee-berts Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval by writing /assign @lauralorenz in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment