search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
209 stars 42 forks source link

Add constant for well-known source cluster label #35

Closed tpantelis closed 1 year ago

tpantelis commented 1 year ago

The MCS spec defines the well-known multicluster.kubernetes.io/source-cluster label so add a constant.

tpantelis commented 1 year ago

/cc @skitt

k8s-ci-robot commented 1 year ago

@tpantelis: GitHub didn't allow me to request PR reviews from the following users: skitt.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/pull/35#issuecomment-1429023172): >/cc @skitt Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
skitt commented 1 year ago

/approve

RainbowMango commented 1 year ago

Hi @tpantelis May I know which spec defined this label? Could you please share a link?

skitt commented 1 year ago

@RainbowMango it’s in KEP-1645, see https://github.com/kubernetes/enhancements/tree/master/keps/sig-multicluster/1645-multi-cluster-services-api#importing-services

RainbowMango commented 1 year ago

Get it. Thanks. /lgtm

/assign @JeremyOT @lauralorenz

tpantelis commented 1 year ago

@RainbowMango it’s in KEP-1645, see https://github.com/kubernetes/enhancements/tree/master/keps/sig-multicluster/1645-multi-cluster-services-api#importing-services

I updated the summary with the link - I should've clarified that before.

lauralorenz commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lauralorenz, skitt, tpantelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)~~ [lauralorenz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment