search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
209 stars 42 forks source link

Upgrade to go 1.19 as 1.18 is out of support #38

Closed jmhbnz closed 1 year ago

jmhbnz commented 1 year ago

We should consider bumping the project go version as 1.18 is no longer supported, refer https://go.dev/doc/devel/release.

jmhbnz commented 1 year ago

Hey @lauralorenz , @JeremyOT - Can you please take a look at this? Thanks! 🙏🏻

jmhbnz commented 1 year ago

Ping @lauralorenz, @JeremyOT - Can you please review this maintenance pr?

lauralorenz commented 1 year ago

/lgtm /approve

also need Dockerfile to be updated in follow on PR

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, lauralorenz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)~~ [lauralorenz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment