search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

update appProtocol definition based to align with k8s 1.27 #39

Closed LiorLieberman closed 1 year ago

LiorLieberman commented 1 year ago

AppProtocol description has changed and new standards were introduced in 1.27 (see https://github.com/kubernetes/kubernetes/pull/116866 & https://github.com/kubernetes/kubernetes/pull/115433 )

Let me know if I should change in other places or run a make command to auto-generate other files

/cc @arkodg

LiorLieberman commented 1 year ago

/cc @robscott

robscott commented 1 year ago

Thanks @LiorLieberman!

/lgtm /assign @lauralorenz

LiorLieberman commented 1 year ago

hey, any updates on this?

lauralorenz commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lauralorenz, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)~~ [lauralorenz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment