search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
210 stars 43 forks source link

Get metav1.Condition on board #4

Closed RainbowMango closed 3 years ago

RainbowMango commented 3 years ago

What type of PR is this? /kind cleanup /kind api-change

What this PR does / why we need it: Replace ServiceExportCondition with metav1.Condition which released at v1.19.0. cc @JeremyOT

RainbowMango commented 3 years ago

/assign @pmorie @JeremyOT Kindly ping...

JeremyOT commented 3 years ago

Thanks for making this change! This is something we definitely want, but since there are a few projects actively using this API, perhaps we should add this as v1alpha2 since it's not quite a drop-in replacement.

RainbowMango commented 3 years ago

Yeah, that makes sense, it's a kind of API change.

since there are a few projects actively using this API

Glad to hear that, but why not make a tagged release for them?

JeremyOT commented 3 years ago

Tagged v0.1.0, I think this makes sense to merge.

/lgtm /approve

JeremyOT commented 3 years ago

/approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeremyOT, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)~~ [JeremyOT] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment