search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
209 stars 42 forks source link

clean: remove unused hello serviceExport defs #46

Closed Xunzhuo closed 1 month ago

Xunzhuo commented 9 months ago

helloServiceExport is not used in anywhere

k8s-ci-robot commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xunzhuo Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

lauralorenz commented 5 months ago

/remove-lifecycle rotten

mikemorris commented 4 months ago

I think this should probably be used at https://github.com/kubernetes-sigs/mcs-api/blob/2833f83cfbdc46d80e0e18111ec977c4ef16e51d/conformance/connectivity_test.go#L92-L93 instead of creating a new ServiceExport inline there.

tpantelis commented 1 month ago

I think this should probably be used at

https://github.com/kubernetes-sigs/mcs-api/blob/2833f83cfbdc46d80e0e18111ec977c4ef16e51d/conformance/connectivity_test.go#L92-L93

instead of creating a new ServiceExport inline there.

I think statically defining the resource objects is fine for the two simple tests we have now. But as we expand the tests, we'll likely want to create more than one service and headless services and maybe alter the service spec. So I think defining them globally/statically becomes less useful and maybe cumbersome. I think it's more useful to have functions to create them, eg createServiceExport(name string) (which I've added locally in a pending commit).

tpantelis commented 1 month ago

This PR can be closed in favor of https://github.com/kubernetes-sigs/mcs-api/pull/60 which is a duplicate but it is newer and active.

skitt commented 1 month ago

Thanks @Xunzhuo for your contribution; I’ve merged #60 which is more comprehensive.

/close

k8s-ci-robot commented 1 month ago

@skitt: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/pull/46#issuecomment-2321110158): >Thanks @Xunzhuo for your contribution; I’ve merged #60 which is more comprehensive. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.