search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

fix: code gen path and boilerplate #47

Closed Xunzhuo closed 4 months ago

Xunzhuo commented 7 months ago

This should be merged after https://github.com/kubernetes-sigs/mcs-api/pull/44

Currently make generate will generate codes in wrong path and boilerplate is not in current year.

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xunzhuo Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Xunzhuo commented 4 months ago

/close

Will reopen one, which does not break current path.

k8s-ci-robot commented 4 months ago

@Xunzhuo: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/pull/47#issuecomment-1979815576): >/close > >Will reopen one, which does not break current path. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.