search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

remove discoveryv1beta1 from e2e tests #51

Open nojnhuh opened 1 month ago

nojnhuh commented 1 month ago

Non-ancient versions of Kubernetes (1.22-ish? and later) do not serve v1beta1 of the discovery APIs which include EndpointSlices. This PR removes logic dealing with that API version, which was only present in the connectivity e2e test.

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nojnhuh Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
skitt commented 2 weeks ago

/lgtm

jackfrancis commented 22 hours ago

@skitt can we merge this?