search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

Allow codegen verification #54

Open skitt opened 6 days ago

skitt commented 6 days ago

Current codegen no longer supports --verify-only; to verify, this generates the code in a temporary directory, and diffs the current code with the newly-generated code. The script exits with the status code of the last command, so it will fail if diff finds any difference.

To correctly account for files which are no longer generated, actual code generation starts by deleting the output directory.

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nojnhuh, skitt Once this PR has been reviewed and has the lgtm label, please assign pmorie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/mcs-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment