search

kubernetes-sigs / mcs-api

This repository hosts the Multi-Cluster Service APIs. Providers can import packages in this repo to ensure their multi-cluster service controller implementations will be compatible with MCS data planes.
Apache License 2.0
199 stars 39 forks source link

make demo: undeclared name: ServiceExport #7

Closed rosenhouse closed 2 years ago

rosenhouse commented 3 years ago

Tried this on master and v0.1.0 tag. Both times make demo gave me:

$ make demo
./hack/update-codegen.sh
go: downloading k8s.io/gengo v0.0.0-20200114144118-36b2048a9120
Generating deepcopy funcs
Generating clientset at sigs.k8s.io/mcs-api/pkg/client/clientset
Generating listers at sigs.k8s.io/mcs-api/pkg/client/listers
Generating informers at sigs.k8s.io/mcs-api/pkg/client/informers
Generating register at sigs.k8s.io/mcs-api/pkg/apis/v1alpha1
go run sigs.k8s.io/controller-tools/cmd/controller-gen object:headerFile=./hack/boilerplate.go.txt paths="./..."
go: downloading k8s.io/apimachinery v0.18.4
go: downloading k8s.io/api v0.18.4
go: downloading k8s.io/utils v0.0.0-20200603063816-c1c6865ac451
go: downloading golang.org/x/net v0.0.0-20200520004742-59133d7f0dd7
go fmt ./...
go vet ./...
go: downloading github.com/onsi/gomega v1.10.1
go: downloading github.com/onsi/ginkgo v1.14.0
# sigs.k8s.io/mcs-api/sigs.k8s.io/mcs-api/pkg/apis/v1alpha1
vet: sigs.k8s.io/mcs-api/pkg/apis/v1alpha1/zz_generated.register.go:61:4: undeclared name: ServiceExport
Makefile:57: recipe for target 'vet' failed
make: *** [vet] Error 2
rosenhouse commented 3 years ago

looks like ./hack/update-codegen.sh is putting files into ./sigs.k8s.io/mcs-api/pkg/apis when they should instead go into just ./pkg/apis

k8s-triage-robot commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

JeremyOT commented 2 years ago

/remove-lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/mcs-api/issues/7#issuecomment-1026238562): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.