search

kubernetes-sigs / metrics-server

Scalable and efficient source of container resource metrics for Kubernetes built-in autoscaling pipelines.
https://kubernetes.io/docs/tasks/debug-application-cluster/resource-metrics-pipeline/
Apache License 2.0
5.79k stars 1.87k forks source link

fix golangci-lint #1457

Closed yangjunmyfm192085 closed 5 months ago

yangjunmyfm192085 commented 6 months ago

What this PR does / why we need it: fix golangci-lint for pr https://github.com/kubernetes-sigs/metrics-server/pull/1403 Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yangjunmyfm192085 Once this PR has been reviewed and has the lgtm label, please assign s-urbaniak for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/metrics-server/blob/release-0.5/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 6 months ago

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yangjunmyfm192085 commented 6 months ago

/cc @dgrisonnet

dgrisonnet commented 5 months ago

Release-0.5 is running on unsupported versions of both Go and Kubernetes, so it is very unlikely that we will push any fixes to it

yangjunmyfm192085 commented 5 months ago

/close

k8s-ci-robot commented 5 months ago

@yangjunmyfm192085: Closed this PR.

In response to [this](https://github.com/kubernetes-sigs/metrics-server/pull/1457#issuecomment-2111870168): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.