Closed jimmy-ungerman closed 1 month ago
Welcome @jimmy-ungerman!
It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @jimmy-ungerman. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
@s-urbaniak hoping I could get a quick review on this
/assign @stevehipwell /triage accepted
Thanks for the PR @jimmy-ungerman. Could you please also add an entry to the chart CHANGELOG for this change and squash your commits?
@stevehipwell Done!
Thanks @jimmy-ungerman.
/ok-to-test
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jimmy-ungerman, stevehipwell
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@stevehipwell is there a pipeline somewhere that will run and update the chart version in chart.yaml? It's still reflecting the old 3.12.1
@jimmy-ungerman the chart release process would need following. Is there a reason why this change needs to be released now?
@stevehipwell I just think it's best practice to increment the chart version anytime a change occurs inside the chart.
@jimmy-ungerman you can request a chart release, but it requires time and effort so it's not something that just happens.
What this PR does / why we need it: Updates the addon-resizer image in the Helm Chart to match the most recent addon-resizer release here