Add conformance test for `.spec.Priority` field in ANP

tssurya commented 1 year ago

This commit adds tests that check if the .spec.Priority field is respected and works as expected. Note that we use Pods field to express Subject and Peers so that we test that aspect unlike the rest of the tests so far which have always used Namespaces aspect.

Looking good here:

    --- PASS: TestConformance/AdminNetworkPolicyIntegration (25.67s)                                                                                                         
        --- PASS: TestConformance/AdminNetworkPolicyIntegration/Should_Deny_traffic_from_slytherin_to_gryffindor_respecting_ANP (6.25s)                                      
        --- PASS: TestConformance/AdminNetworkPolicyIntegration/Should_Deny_traffic_to_slytherin_from_gryffindor_respecting_ANP (6.29s)                                      
        --- PASS: TestConformance/AdminNetworkPolicyIntegration/Should_support_a_'pass-ingress'_policy_for_ANP_and_respect_the_match_for_network_policy (0.24s)              
        --- PASS: TestConformance/AdminNetworkPolicyIntegration/Should_support_a_'pass-egress'_policy_for_ANP_and_respect_the_match_for_network_policy (0.20s)               
        --- PASS: TestConformance/AdminNetworkPolicyIntegration/Should_support_a_'pass-ingress'_policy_for_ANP_and_respect_the_match_for_baseline_admin_network_policy (6.35s
)                                                                                                                                                                            
        --- PASS: TestConformance/AdminNetworkPolicyIntegration/Should_support_a_'pass-egress'_policy_for_ANP_and_respect_the_match_for_baseline_admin_network_policy (6.28s)
    --- PASS: TestConformance/AdminNetworkPolicyPriorityField (13.25s)                                                                                                       
        --- PASS: TestConformance/AdminNetworkPolicyPriorityField/Should_Deny_traffic_from_slytherin_to_gryffindor_respecting_ANP (6.27s)                                    
        --- PASS: TestConformance/AdminNetworkPolicyPriorityField/Should_Deny_traffic_to_slytherin_from_gryffindor_respecting_ANP (6.38s)                                    
        --- PASS: TestConformance/AdminNetworkPolicyPriorityField/Should_respect_ANP_priority_field;_thus_passing_both_ingress_and_egress_traffic_over_to_BANP (0.53s)

netlify[bot] commented 1 year ago

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name	Link
Latest commit	c43707a70534917ae52f953ddcecba685c694ab8
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/649f16a11a6d0c000829fce9
Deploy Preview	https://deploy-preview-113--kubernetes-sigs-network-policy-api.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tssurya commented 1 year ago

/test network-policy-api-crd-e2e

k8s-ci-robot commented 1 year ago

@tssurya: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test pull-network-policy-api-crd-e2e
/test pull-network-policy-api-verify

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/network-policy-api/pull/113#issuecomment-1567112656): >/test network-policy-api-crd-e2e Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tssurya commented 1 year ago

/test pull-network-policy-api-crd-e2e

astoycos commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/network-policy-api/blob/master/OWNERS)~~ [astoycos] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / network-policy-api